HBASE-29782 Expose public Admin API to reopen table regions without moving #7563
+792
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmdmattingly
requested review from
charlesconnell,
ndimiduk and
rmdmattingly
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
charlesconnell
approved these changes
Dec 18, 2025
ndimiduk
reviewed
Dec 18, 2025
| } | ||
|
|
||
| ReopenTableRegionsProcedure(final TableName tableName, long reopenBatchBackoffMillis, | ||
| public ReopenTableRegionsProcedure(final TableName tableName, long reopenBatchBackoffMillis, |
Member
There was a problem hiding this comment.
Why have you made these public?
Contributor
Author
There was a problem hiding this comment.
To use in an integration test - do I need to annotate the methods in some way to indicate they are only exposed for testing? Something akin to @VisibleForTesting from Guava perhaps?
Member
There was a problem hiding this comment.
If there's going to be a subsequent PR that introduces the integration test, please wait and make the change then.
Yes, my recollection is that there is a VisibleForTesting on the classpath. I don't think we use its presence for any static enforcement, but it is useful enough to communicate intent. IMHO a comment is sufficient.
| * @return procedure Id | ||
| * @throws IOException if reopening region fails while running procedure | ||
| */ | ||
| long reopenRegionsThrottled(final TableName tableName, final List<byte[]> regionNames, |
Member
There was a problem hiding this comment.
Throttling is a net new feature with this change? I'm surprised it's not introduced as a separate feature.
Contributor
Author
There was a problem hiding this comment.
Throttling has already been implemented in the ReopenTableRegionsProcedure, but for some reason the existing method on HMaster doesn't use it. I didn't want to change the existing implementation so I exposed a new method to allow users to choose - and used it for these changes too.
Member
There was a problem hiding this comment.
Please file a ticket to report the other flow not making use of this method? We should centralize the implementations if we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds fail-fast validation that throws UnknownRegionException when callers attempt to reopen regions that don't belong to the specified table, preventing silent failures and configuration errors in production. The implementation removes unused batch parameters from the API in favor of configuration-based throttling (via table descriptor or global config), ensuring consistent behavior between reopening all regions and specific subsets. Exception handling now properly fails procedures for DoNotRetry errors rather than infinitely retrying validation failures.
JIRA: https://issues.apache.org/jira/browse/HBASE-29782