Skip to content

[FLINK-38260] Add parser changes for connection sql #27251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 1, 2025
Merged

[FLINK-38260] Add parser changes for connection sql #27251

merged 6 commits into from
Dec 1, 2025

Conversation

@lihaosky
Copy link
Contributor

@lihaosky lihaosky commented Nov 19, 2025

What is the purpose of the change

Add connection sql parser changes for FLIP-529

Brief change log

Parser changes for connection ddl, dql

Verifying this change

Added parser test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 19, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Nov 19, 2025
@snuyanzin
Copy link
Contributor

snuyanzin commented Nov 20, 2025 •
edited
Loading

fyi: to have green ci, rebase to the latest master
e2e was fixed at FLINK-38700

@snuyanzin
Copy link
Contributor

snuyanzin commented Nov 21, 2025 •
edited
Loading

seems we have a lot more issue in parser
we committed refactoring PR on that (#27256)

would be great if you can adapt your PR and then we can merge it

snuyanzin
snuyanzin reviewed Nov 22, 2025
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I added some minor comments to improve reuse

I guess should be good to merge with next iteration

snuyanzin
snuyanzin approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback

@snuyanzin snuyanzin merged commit 321b17f into apache:master Dec 1, 2025
@snuyanzin snuyanzin deleted the connection-sql-syntax branch December 1, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snuyanzin snuyanzin snuyanzin approved these changes

+1 more reviewer

@davidradl davidradl davidradl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lihaosky @flinkbot @snuyanzin @davidradl