[impv] Remove tenant define is workflow #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongjiajie
force-pushed
the
i-rm-tenant
branch
from
8f42ab7 to
a410e91
Compare
zhongjiajie
added
improvement
Member
Author
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 60 60
Lines 2119 2119
=======================================
Hits 1924 1924
Misses 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in apache#40 we try to create both user and tenant vis cli instead of auto create
zhongjiajie
force-pushed
the
i-rm-tenant
branch
from
169d955 to
406568c
Compare
jieguangzhou
approved these changes
Dec 19, 2022
Member
Author
|
may release in version apache/dolphinscheduler:3.1.5 |
zhongjiajie
removed
the
dep-main-repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of The Change
current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in #40 we try to create both user and tenant vis cli instead of auto create
Pull Request checklist
I confirm that the following checklist has been completed.
docs/source/config.rstwhen you change filedefault_config.yaml.UPDATING.mdwhen it is an incompatible change.