Chore: Refactor static invoke exprs #2671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
============================================
+ Coverage 56.12% 58.52% +2.39%
- Complexity 976 1444 +468
============================================
Files 119 160 +41
Lines 11743 13892 +2149
Branches 2251 2368 +117
============================================
+ Hits 6591 8130 +1539
- Misses 4012 4568 +556
- Partials 1140 1194 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 4 commits
November 1, 2025 21:39
# Conflicts: # spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
andygrove
approved these changes
Nov 12, 2025
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @kazantsev-maksim
comphead
approved these changes
Nov 12, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @kazantsev-maksim for the contribution, I was not quite sure about naming statics as looks like it would be a one trick pony as no other statics, but it is okay for now!
Contributor
Author
|
@andygrove @comphead thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of: #2443
Rationale for this change
Part of: #2443
What changes are included in this PR?
How are these changes tested?
Tested with existing unit tests