-
Notifications
You must be signed in to change notification settings - Fork 298
Add failing tests to reproduce POOL-426 #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: POOL_2_X
Are you sure you want to change the base?
Conversation
|
@garydgregory @psteitz Requesting critical review for the fix for POOL-426. Thanks! |
|
Hi @psteitz Any thoughts on this one? |
|
Analysis looks correct to me. This plus revert of bugged fix for POOL-425 should work. I am having trouble getting the patch applied to the right branch. Will review and merge once fully tested. Thanks for the patch. |
|
I can cut a release candidate when we have a fix validated. |
|
Added a test for POOL-413 as well. |
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.See https://issues.apache.org/jira/browse/POOL-426 for more details.