Show volume UUIDs in the backup details page #12156
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
DaanHoogland
requested review from
abh1sar and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR updates the backup details page to display volume UUIDs instead of backup file storage UUIDs, improving clarity for users when viewing backup volume information.
Key Changes:
- Modified the volume display in the backup details to show the volume UUID instead of the volume path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12156 +/- ##
============================================
+ Coverage 17.56% 17.57% +0.01%
- Complexity 15540 15549 +9
============================================
Files 5909 5913 +4
Lines 529059 529508 +449
Branches 64617 64702 +85
============================================
+ Hits 92919 93061 +142
- Misses 425687 425991 +304
- Partials 10453 10456 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
IMO simply replacing path with uuid might cause more confusion for people who are used to it. If the confusion is about what the string represents, can we prefix it with "path: " |
| <div v-for="(volume, idx) in JSON.parse(dataResource[item])" :key="idx"> | ||
| <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> | ||
| <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.uuid }}</router-link> | ||
| <span v-else>{{ volume.type }} - {{ volume.path }}</span> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB) |
There was a problem hiding this comment.
@Tonitzpp, what happens when the workflow reaches the v-else statement (line 68)? Should volume.path be displayed then?
|
@abh1sar the path displayed in the GUI is not the backup file path, but the volume path. Furthermore, end users do not have access to the storage to "check the files"; thus, this information is not very valuable to them. On the other hand, displaying the volume UUID is much more useful, as it facilitates API usage. |
|
this change should not cause regressions in GHA |
|
retrying |
4 participants
Description
When accessing the details of a backup in the UI, all the volumes that are part of the backup are listed. However, the listing displays a UUID that does not identify the volume, but it's path in the storage, which can cause confusion for users. This PR changed the listing details to display the UUID of the volumes.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Backup volumes before changes:
Volume path:
Backup volume:
Backup volumes after changes:
Volume path:
Backup volume:
How Has This Been Tested?
I created a VM to perform the tests and assigned it a backup offering. After that I created a backup and verified that the volumes UUID had been changed to their respective UUID in the backup details.
How did you try to break this feature and the system with this change?