Skip to content

Conversation

@arunpandianp
Copy link
Contributor

@arunpandianp arunpandianp commented Dec 19, 2025

This adds a new way of encoding windmill state tags and timer tags.
The new code is behind an unstable experiment. More work is needed
before it can be used on real workloads.

This is on top of #37150.

This adds a new way of encoding windmill state tags and timer tags.
The new code is behind an unstable experiment. More work is needed
before it can be used on real workloads.
@arunpandianp
Copy link
Contributor Author

R: @scwhittle

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural change to how state and timer tags are encoded within the Windmill backend for Dataflow streaming jobs. By abstracting the encoding logic behind a new WindmillTagEncoding interface, it paves the way for WindmillTagEncodingV2, an experimental encoding scheme. This refactoring allows for future improvements in efficiency or functionality of tag handling, with the new version being opt-in via an experiment flag for cautious evaluation.

Highlights

  • New Windmill Tag Encoding (V2): Introduced WindmillTagEncodingV2, a new way of encoding Windmill state tags and timer tags. This new encoding is currently behind an unstable experiment flag and is not yet ready for production workloads.
  • Refactoring with WindmillTagEncoding Interface: A new abstract class WindmillTagEncoding has been added, defining a common interface for encoding state and timer tags. The existing WindmillStateTagUtil has been renamed to WindmillTagEncodingV1 and now implements this interface, maintaining backward compatibility.
  • Dynamic Encoding Selection: The StreamingModeExecutionContext now dynamically selects between WindmillTagEncodingV1 and WindmillTagEncodingV2 based on an experiment flag, allowing for controlled rollout and testing of the new encoding.
  • Core State API Enhancements: Added getWindowCoder() methods to StateNamespaces classes and getKind() and isSystemTagInternal() methods to StateTags to support the new encoding logic.
  • Widespread Integration: Multiple components, including WindmillKeyedWorkItem, WindmillTimerInternals, CachingStateTable, WindmillCombiningState, and WindmillStateInternals, have been updated to use the new WindmillTagEncoding interface, ensuring consistent tag handling across the Dataflow worker.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@scwhittle scwhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial comments, might be able to merge/rebase since the base refactoring is merged. I'll be OOO for two weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants