-
Notifications
You must be signed in to change notification settings - Fork 159
ARIES-2165: Update parent pom and build web on Java 11, 17 and 21 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As I plan a new proxy and blueprint releases with JDK 17/21 support, let me quickly review/test this change. |
| @@ -1,203 +0,0 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, any artifact we distribute should have a clean LICENSE and NOTICE. I agree to remove for now, I will do a complete pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed on mailing list that there is plugin in parent pom that add these file during build, please check #410
web/web-itests/pom.xml
Outdated
| <org.apache.aries.blueprint.sample.version>1.0.0</org.apache.aries.blueprint.sample.version> | ||
| <org.apache.aries.blueprint.version>1.0.0</org.apache.aries.blueprint.version> | ||
| <org.apache.aries.proxy.version>1.0.1</org.apache.aries.proxy.version> | ||
| <org.apache.aries.proxy.version>1.1.14</org.apache.aries.proxy.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this proxy release fully supports JDK 17+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not
there is a problem with sun classes even in java 11+
You can take a look at #414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web does not use proxy at all so I removed the dependency together with unused blueprint dependencies
web/web-itests/pom.xml
Outdated
| <org.eclipse.osgi.version>3.11.3</org.eclipse.osgi.version> | ||
| <slf4j-api.version>1.7.7</slf4j-api.version> | ||
| <org.apache.felix.configadmin.version>1.9.26</org.apache.felix.configadmin.version> | ||
| <org.eclipse.osgi.version>3.16.0</org.eclipse.osgi.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried setting the newest version 3.22.0 as it is in quiesce-manager-itest, but the container is not starting with error:
Security class "org.osgi.service.log.LogLevel"'s signer information does not match signer information of other classes in the same package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When order of dependencies is changed then this error dissappears but the highest eclipse version to use now is 3.17.0
Higher versions has WABs generated with missing headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cause in the new versions of eclipse seems to be that url is:
webbundle:file:/tmp/test7207230737428988734.war?Bundle-SymbolicName=test.war.bundle&Web-ContextPath=foo
and new eclipse ignores generated input stream because sourceUrl has protocol file in https://github.com/eclipse-equinox/equinox/blob/e35221a86afd24ee21b7b9d02db298a90ace1bc0/bundles/org.eclipse.osgi/container/src/org/eclipse/osgi/storage/Storage.java#L1158-L1181
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fc00275 to
c0090cf
Compare
No description provided.