-
Notifications
You must be signed in to change notification settings - Fork 365
feat: support deployment of multiple data plane modes #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -127,6 +127,11 @@ spec: | |||||||||||||||||
| type: string | ||||||||||||||||||
| minItems: 1 | ||||||||||||||||||
| type: array | ||||||||||||||||||
| mode: | ||||||||||||||||||
| description: |- | ||||||||||||||||||
| Mode specifies the mode of control plane provider. | ||||||||||||||||||
| Can be `apisix` or `apisix-standalone`. | ||||||||||||||||||
| type: string | ||||||||||||||||||
AlinsRan marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||
| service: | ||||||||||||||||||
| properties: | ||||||||||||||||||
| name: | ||||||||||||||||||
|
|
@@ -150,6 +155,9 @@ spec: | |||||||||||||||||
| type: object | ||||||||||||||||||
| x-kubernetes-validations: | ||||||||||||||||||
| - rule: has(self.endpoints) != has(self.service) | ||||||||||||||||||
| - message: mode is immutable | ||||||||||||||||||
| rule: oldSelf == null || (!has(self.mode) && !has(oldSelf.mode)) | ||||||||||||||||||
| || self.mode == oldSelf.mode | ||||||||||||||||||
|
Comment on lines
+158
to
+160
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the aim here? What might occur if we do not prohibit this modification? 🤔
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
However, please confirm: if I delete the GatewayProxy resource and recreate it with the same name using a different mode, no resources will be deleted in cascade, and the Ingress Controller will begin pushing configurations in the new mode, correct? Once you have confirmed the issue, I shall approve and merge it. We will keep this restriction in place for the time being.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Essentially, yes. Each backend establishes its own cache based on its requirements and maintains it internally without sharing. The type will be determined by the |
||||||||||||||||||
| type: | ||||||||||||||||||
| description: Type specifies the type of provider. Can only be | ||||||||||||||||||
| `ControlPlane`. | ||||||||||||||||||
|
|
||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.