[v3-1-test] Sqlalchemy 2.0 changes (test_types.py, test_manager.py, test_processor.py) (#59748) #59784
+21
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est_processor.py) (apache#59748) * Update sqlalchemy compatible change for test_types.py * Compatibility fixes * Update sqlalchemy compatible change for test_manager.py * Update sqlalchemy compatible change for test_processor.py * Review fix (cherry picked from commit 9e9874f) Co-authored-by: Kunal Bhattacharya <kunal.bhattacharya@pepsico.com>
Contributor
|
Thanks !! @jscheffl but I don't understand why do we need to create the same PR for |
Contributor
Author
|
Actually this is just a backport for maintenance of the 3.1 branch. I back-ported to keep the diff to upstream smaller. But not needed - except to keep maintenance easier. And: No need for you to create another branch, either the CI will make it or the maintainer who merges is responsible - see: https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sqlalchemy compatible change for test_types.py
Compatibility fixes
Update sqlalchemy compatible change for test_manager.py
Update sqlalchemy compatible change for test_processor.py
Review fix (cherry picked from commit 9e9874f)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.