Add stream method for GCSRemoteIO #59753
Open
+309
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
provider:google
jason810496
force-pushed
the
refactor/logging/add-stream-method-for-gcs
branch
2 times, most recently
from
ceb0aa3 to
f6a6b6f
Compare
Fix missing mock for get_credentials_and_project_id Fix mypy error Fix test
Skip 2.11 test
jason810496
force-pushed
the
refactor/logging/add-stream-method-for-gcs
branch
from
f6a6b6f to
7600c5d
Compare
jason810496
requested review from
Lee-W,
amoghrajesh,
ashb,
pankajkoti and
potiuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #49470, #54813
Why
After Resolve OOM When Reading Large Logs in Webserver #49470 and Add stream method to RemoteIO #54813, we now support memory efficient stream-based read interface (
RemoteIO.streammethod) when reading TaskInstance Logs, but we still need to implement thestreammethod for corresponding RemoteIO on provider side to make the whole reading path memory efficient.What
streammethod onGCSRemoteIOto make TaskInstance Log reading path memory efficientreadmethod to callstreammethod instead of duplicating common logicVerification
I tested the change across the following Airflow versions.
3.2.0(mainbranch )GCSRemoteIO.streammethodbreeze start-airflow --backend postgres --mount-sources providers-and-tests --use-airflow-version apache/airflow:main3.1.5GCSRemoteIO.readmethodbreeze start-airflow --backend postgres --mount-sources providers-and-tests --use-airflow-version 3.1.52.11.0GCSRemoteIO.readmethodbreeze start-airflow --backend postgres --mount-sources providers-and-tests --use-airflow-version 2.11.0