Skip to content

fix(ng-dev): only log failures to when on actual failing exit codes when on-error mode is set #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josephperrott wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

fix(ng-dev): only log failures to when on actual failing exit codes when on-error mode is set #3307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/local-actions/branch-manager/main.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions ng-dev/utils/child-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ export interface CommonCmdOpts {

/** Interface describing the options for spawning a process synchronously. */
export interface SpawnSyncOptions
extends CommonCmdOpts,
Omit<_SpawnSyncOptions, 'shell' | 'stdio' | 'input'> {}
extends CommonCmdOpts, Omit<_SpawnSyncOptions, 'shell' | 'stdio' | 'input'> {}

/** Interface describing the options for spawning a process. */
export interface SpawnOptions extends CommonCmdOpts, Omit<_SpawnOptions, 'shell' | 'stdio'> {}
Expand Down Expand Up @@ -222,9 +221,8 @@ function processAsyncCmd(
// stderr due to a race condition around exiting.
childProcess.on('close', (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = options.mode === 'on-error' ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);

const printFn = status !== 0 && options.mode === 'on-error' ? Log.error : Log.debug;
printFn(`Command "${command}" completed with ${exitDescription}.`);
printFn(`Process output: \n${logOutput}`);

Expand Down
Loading