Skip to content

Revert "fix(ng-dev): don't run the pnpm run script spawn as silent mode" #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephperrott merged 1 commit into from
Dec 11, 2025
Merged

Revert "fix(ng-dev): don't run the pnpm run script spawn as silent mode" #3304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ng-dev/release/publish/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export abstract class ReleaseAction {
// cause the pnpm install from within Bazel to errantly attempt to install a package that
// does not exist.
try {
this.git.run(['clean', '-dfX', '**/node_modules']);
this.git.run(['clean', '-qdfX', '**/node_modules']);
} catch {}
await ExternalCommands.invokePnpmInstall(this.projectDir);
return;
Expand All @@ -405,7 +405,7 @@ export abstract class ReleaseAction {
// we might be able to fix this with Yarn 2+, it is reasonable ensuring clean node modules.
// TODO: Remove this when we use Yarn 2+ in all Angular repositories.
try {
this.git.run(['clean', '-dfX', '**/node_modules']);
this.git.run(['clean', '-qdfX', '**/node_modules']);
} catch {}
await ExternalCommands.invokeYarnInstall(this.projectDir);
}
Expand Down
2 changes: 1 addition & 1 deletion ng-dev/release/publish/external-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export abstract class ExternalCommands {
spawnOptions: SpawnOptions = {},
): Promise<SpawnResult> {
if (PnpmVersioning.isUsingPnpm(projectDir)) {
return ChildProcess.spawn('npx', ['--yes', 'pnpm', 'run', ...args], {
return ChildProcess.spawn('npx', ['--yes', 'pnpm', '-s', 'run', ...args], {
...spawnOptions,
cwd: projectDir,
});
Expand Down
Loading