Skip to content

fix(material/chips): emit state changes when chip grid is disabled #30033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(material/chips): emit state changes when chip grid is disabled #30033

merged 1 commit into from
Nov 20, 2024

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 18, 2024

Fixes that the chip grid wasn't emitting to its stateChanges when it becomes disabled which meant that the parent form field might not update correctly.

Fixes #30017.

@crisbeto
fix(material/chips): emit state changes when chip grid is disabled
51c71c9 
Fixes that the chip grid wasn't emitting to its `stateChanges` when it becomes disabled which meant that the parent form field might not update correctly.

Fixes angular#30017.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 18, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 18, 2024 09:21
@crisbeto crisbeto requested review from andrewseguin and mmalerba and removed request for a team November 18, 2024 09:21
@crisbeto crisbeto removed the request for review from andrewseguin November 18, 2024 17:54
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 18, 2024
@crisbeto crisbeto merged commit 8980ad5 into angular:main Nov 20, 2024
24 checks passed
crisbeto added a commit that referenced this pull request Nov 20, 2024
@crisbeto
fix(material/chips): emit state changes when chip grid is disabled (#…
edac406 
…30033)

Fixes that the chip grid wasn't emitting to its `stateChanges` when it becomes disabled which meant that the parent form field might not update correctly.

Fixes #30017.

(cherry picked from commit 8980ad5)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 21, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(mat-chip-grid): mat-form-field disabled state doesn't get updated when setting [disabled]=false on the mat-chip-grid element

2 participants

@crisbeto @mmalerba