Skip to content

feat(proposal): memoized children list, refactored code #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(proposal): memoized children list, refactored code #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,33 @@
/* eslint-disable react/jsx-no-useless-fragment */
import * as React from 'react';
import React, { memo, useMemo } from "react";

type WhenProps = {
children: React.ReactNode,
isTrue?: boolean,
limit?: number,
};
type WhenProps = React.PropsWithChildren<{
condition?: boolean;
limit?: number;
}>;

const RenderWhen = ({ limit, isTrue, children }:WhenProps) => {
const list:React.ReactNode[] = [];
const Wrapper: React.FC<WhenProps> = memo(
({ limit = 1, condition = true, children }) => {
const list = useMemo(() => {
return React.Children.map(children, (child) => {
const { condition: childCondition } = child?.props || {};

if (isTrue !== true) {
return null;
}

React.Children.map(children, (child:any) => {
const { isTrue: isChildTrue } = child?.props || {};

if (isChildTrue === true && list.length < limit) {
list.push(child);
if (childCondition && list.length < limit) {
Copy link

@wambuguedison wambuguedison Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on this line (col 31) throws a ts error

'list' is possibly 'null' or 'undefined'.`

return child;
}
});
});
}, [children, limit]);

return (
<>
{list}
</>
);
};
if (!condition) {
return null;
}

RenderWhen.defaultProps = {
limit: 1,
isTrue: true,
};
return <>{list}</>;
}
);

RenderWhen.If = ({ children, isTrue }) => children;
const If: React.FC<WhenProps> = memo(({ children }) => {
Copy link

@wambuguedison wambuguedison Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on this line, (col 41) throws this error

  Overload 1 of 2, '(Component: FunctionComponent<{ condition?: boolean | undefined; limit?: number | undefined; } & { children?: ReactNode; }>, propsAreEqual?: ((prevProps: Readonly<{ condition?: boolean | undefined; limit?: number | undefined; } & { ...; }>, nextProps: Readonly<...>) => boolean) | undefined): NamedExoticComponent<...>', gave the following error.
    Argument of type '({ children }: { condition?: boolean | undefined; limit?: number | undefined; } & { children?: ReactNode; }) => ReactNode' is not assignable to parameter of type 'FunctionComponent<{ condition?: boolean | undefined; limit?: number | undefined; } & { children?: ReactNode; }>'.
      Type 'ReactNode' is not assignable to type 'ReactElement<any, any> | null'.
        Type 'undefined' is not assignable to type 'ReactElement<any, any> | null'.
  Overload 2 of 2, '(Component: ComponentType<any>, propsAreEqual?: ((prevProps: Readonly<any>, nextProps: Readonly<any>) => boolean) | undefined): MemoExoticComponent<ComponentType<any>>', gave the following error.
    Argument of type '({ children }: { condition?: boolean | undefined; limit?: number | undefined; } & { children?: ReactNode; }) => ReactNode' is not assignable to parameter of type 'ComponentType<any>'.
      Type '({ children }: { condition?: boolean | undefined; limit?: number | undefined; } & { children?: ReactNode; }) => ReactNode' is not assignable to type 'FunctionComponent<any>'.
        Type 'ReactNode' is not assignable to type 'ReactElement<any, any> | null'.

return children;
});

export default RenderWhen;
export default { Wrapper, If };