Skip to content

Conversation

@millotp
Copy link
Contributor

@millotp millotp commented Sep 19, 2025

🧭 What and Why

Noticed by @kai687, we don't validate dart snippets and some helpers that we call in the snippets don't exists.
We can remove the snippets for now, and validate dart files so this doesn't happen again.

@millotp millotp self-assigned this Sep 19, 2025
@millotp millotp requested a review from a team as a code owner September 19, 2025 12:32
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 19, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 9343d72c7a2692538dd0d6c39385cca67add49ef
🍃 Generated commit 5f12d135beee5123e10d8545e5b7e00a32c35fdd
🌲 Generated branch generated/fix/dart-helpers
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1722
javascript 1686
php 1533
csharp 1323
python 1156
java 988
ruby 809
swift 395
scala 23

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@millotp millotp changed the title fix(snippets): remove snippets for non-existing helpers snippets: remove snippets for non-existing helpers Sep 19, 2025
@millotp millotp enabled auto-merge (squash) September 19, 2025 12:46
@millotp millotp merged commit 8ce3aad into main Sep 19, 2025
29 of 30 checks passed
@millotp millotp deleted the fix/dart-helpers branch September 19, 2025 12:50
algolia-bot added a commit that referenced this pull request Sep 19, 2025
…) [skip ci]

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants