Skip to content

feat(specs): add lastUpdatedAt to personalization real-time user #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shortcuts merged 5 commits into from
Jul 17, 2025
Merged

feat(specs): add lastUpdatedAt to personalization real-time user #5126

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9fd7c2
feat(predict): add lastUpdatedAt to real-time user
raed667 Jul 17, 2025
50b9231
feat(predict): add lastUpdatedAt to real-time user
raed667 Jul 17, 2025
eb80095
feat(predict): add lastUpdatedAt to real-time user
raed667 Jul 17, 2025
25b96df
add description & example
raed667 Jul 17, 2025
6e7f754
add description & example
raed667 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specs/advanced-personalization/common/schemas/RealtimeUser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ RealtimeUser:
required:
- version
- userID
- lastUpdatedAt
- search
properties:
version:
Expand All @@ -13,6 +14,8 @@ RealtimeUser:
userID:
type: string
description: User ID of the user.
lastUpdatedAt:
type: string
Copy link
Member

@shortcuts shortcuts Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we add the format it's useful for languages that need to parse it .e.g Golang

Copy link
Contributor Author

@raed667 raed667 Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 addressed in 6e7f754

Copy link
Contributor

@bengreenbank bengreenbank Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go further with this: https://swagger.io/docs/specification/v3_0/data-models/data-types/#strings

Suggested change
type: string
type: string
format: date-time

Copy link
Member

@shortcuts shortcuts Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we purposely not use date-time because it forces the user to construct objects (e.g. new Date()), in some languages it's a lot of overhead

search:
type: object
description: |
Expand Down
Loading