fix(php): batchSize docblocks type #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec for these looks correct, so I am guessing this template is the cause for the erroneous docblocks in the generated client code.
shortcuts
approved these changes
Jul 15, 2025
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
oops great catch! thanks a lot
algolia-bot
added a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Rob <rob.bast@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jul 15, 2025
algolia/api-clients-automation#5109 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Rob <rob.bast@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Contributor
Author
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec for these looks correct, so I am guessing this template is the cause for the erroneous docblocks in the generated client code.
🧭 What and Why
Incorrect type docblocks for parameters
🎟 JIRA Ticket:
Changes included:
🧪 Test