Skip to content

fix(specs): abtest v3 naming conflict with Metric type #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shortcuts merged 5 commits into from
Jul 15, 2025
Merged

fix(specs): abtest v3 naming conflict with Metric type #5090

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a87cdc3
fix(spec): abtest v3 naming conflict with Metric type
cdhawke Jul 10, 2025
62f9e18
fix: metric name in timeseries
cdhawke Jul 10, 2025
163c50b
feat: reduce confusion further
cdhawke Jul 10, 2025
3239b30
Merge branch 'main' into fix/abtests/spec
shortcuts Jul 15, 2025
f29ebb9
Merge branch 'main' into fix/abtests/spec
shortcuts Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/abtesting-v3/common/schemas/Timeseries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ metricDate:
metrics:
$ref: 'Variant.yml#/metrics'

Metric:
MetricName:
type: string
enum:
- search_count
Expand Down
4 changes: 2 additions & 2 deletions specs/abtesting-v3/common/schemas/Variant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ metrics:
type: array
description: All ABTest metrics that were defined during test creation.
items:
$ref: '#/metric'
$ref: '#/metricResult'

metric:
metricResult:
type: object
properties:
name:
Expand Down
2 changes: 1 addition & 1 deletion specs/abtesting-v3/paths/timeseries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ get:
schema:
type: array
items:
$ref: '../common/schemas/Timeseries.yml#/Metric'
$ref: '../common/schemas/Timeseries.yml#/MetricName'
responses:
'200':
description: OK
Expand Down