fix(go): handle HTML errors [skip-bc] #4096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
force-pushed
the
fix/go-err-handling
branch
from
4a67c4d to
be36096
Compare
millotp
changed the title
shortcuts
reviewed
Nov 13, 2024
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
looks much cleaner! let's not forget to add a test when we do other clients
algolia-bot
added a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Nov 13, 2024
algolia/api-clients-automation#4096 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
millotp
added a commit
that referenced
this pull request
Nov 18, 2024
millotp
added a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
GCP Cloud Armor can return raw HTML error, we can catch them and handle them gracefully instead of failing the json deserialization.