Skip to content

fix(specs): remove parentID from ingestion specs [skip-bc] #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix(specs): remove parentID from ingestion specs [skip-bc] #3981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a30c085
fix(scripts): properly generate commit
shortcuts Oct 17, 2024
ca7f172
fix: remove parentID
shortcuts Oct 17, 2024
b814d07
chore: java gatekeeping
shortcuts Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions scripts/ci/codegen/pushGeneratedCode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,10 @@ export async function pushGeneratedCode(): Promise<void> {
return;
}

let baseMessage = `%s ${text.commitEndMessage}`;
if (IS_RELEASE_COMMIT || isMainBranch) {
console.log('Processing release commit');
baseMessage = `${text.commitReleaseMessage} [skip ci]`;
}
let baseMessage = IS_RELEASE_COMMIT && isMainBranch ? text.commitReleaseMessage : `%s ${text.commitEndMessage}`;

const commitMessage = await run(
`git show -s ${baseBranch} --format="${baseMessage}
`git show -s ${baseBranch} --format="${baseMessage} [skip-ci]

Co-authored-by: %an <%ae>
%(trailers:key=Co-authored-by)"`,
Expand Down
4 changes: 0 additions & 4 deletions specs/ingestion/common/schemas/event.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ Event:
$ref: './common.yml#/eventID'
runID:
$ref: './common.yml#/runID'
parentID:
type: string
description: The parent event, the cause of this event.
example: 6c02aeb1-775e-418e-870b-1faccd4b2c0f
status:
$ref: '#/EventStatus'
type:
Expand Down
Loading