Skip to content

Conversation

@UbayGD
Copy link
Contributor

@UbayGD UbayGD commented Mar 8, 2025

Hi! :)

I think this small change should correct what is commented in this issue #252.

If you see something that can be improved, feel free to comment and I will try to do my best.

Thank you very much!

@UbayGD UbayGD changed the title Add support for single line comments in JavaScript and TypeScript Issue 252: Add named sections support for JavaScript and TypeScript Mar 13, 2025
@nausharipov nausharipov assigned nausharipov and UbayGD and unassigned nausharipov Mar 25, 2025
@nausharipov nausharipov self-requested a review March 25, 2025 12:15
Copy link
Collaborator

@nausharipov nausharipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nausharipov nausharipov merged commit 0978660 into akvelon:main Mar 25, 2025
2 checks passed
@UbayGD UbayGD deleted the feature/add-single-line-comments-ts-js branch March 25, 2025 20:15
razankv13 added a commit to zingdata/flutter-code-editor that referenced this pull request Oct 20, 2025
This merge brings in important bug fixes and features from main while preserving
all autocomplete/suggestions improvements from improve-editor branch.

Changes from main integrated:
- Flutter/Dart version upgrade (3.22.2/3.4.3)
- Dispose fixes (akvelon#298): Added _disposed flag and mounted checks
- UndoHistoryController support (akvelon#302)
- Line height in default text style fix (akvelon#297)
- YAML support and comments (akvelon#305, akvelon#199)
- JS/TS single line comments (akvelon#291)
- Paired symbols support (akvelon#192)
- Line numbers alignment fix (akvelon#307)
- Pull request template
- Various dependency updates

Changes preserved from improve-editor:
- Refactored code_controller structure (directory with helpers)
- SQL formatter and suggestions logic
- Word insertion helper
- Popup positioning improvements
- Gutter scrollbar hiding
- Browser detection enhancements
- All autocomplete/suggestions improvements

Conflicts resolved:
- code_field.dart: Integrated dispose, undo, and line height fixes
- code_controller.dart: Kept refactored structure, added dispose fix
- gutter.dart: Kept scrollbar hiding feature
- popup.dart & popup_controller.dart: Kept positioning improvements
- parser_factory.dart: Added YAML support with package imports

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants