CI: fix matrix spec / fix broken bin/benchmark.sh #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update rails to 8.0 * Modify the settings in config/environments/test (the setting for action_dispatch.show_exceptions has changed in Rails 7.2). * Change debugger gem 'byebug' to 'debug'
AZQ1994
approved these changes
May 8, 2025
AZQ1994
reviewed
May 8, 2025
simple_json.gemspec
Outdated
| spec.add_development_dependency 'test-unit-rails' | ||
| spec.add_development_dependency 'mutex_m' | ||
|
|
||
| spec.required_ruby_version = '>= 2.5.0' |
Member
There was a problem hiding this comment.
Maybe we should update this too.
I remember some new syntax failed in old versions on CI,
since we don't check them any more, maybe we should deprecate old versions.
Contributor
Author
There was a problem hiding this comment.
excluded EOL Ruby versions. (following ci changes) 213a821
AZQ1994
reviewed
May 8, 2025
| Rails.application.config.generators.simple_json false | ||
| ``` | ||
|
|
||
| ## Benchmarks |
Member
There was a problem hiding this comment.
Let's update these benchmark results.
Contributor
Author
There was a problem hiding this comment.
Currently, bin/benchmark.sh can not running in RAILS_ENV=production. I plan to fix this issue in a separate PR (and will be update bench result).
AZQ1994
reviewed
May 8, 2025
fumihumi
force-pushed
the
update-dependencies
branch
from
ee4cc85 to
213a821
Compare
AZQ1994
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dependencies are updated.
As part of this fix, new (?) warnings are now displayed in “rake test” and other places. However, this issue has not been fixed in this pull request and will be addressed separately.