Skip to content

Conversation

@akakiyo
Copy link
Contributor

@akakiyo akakiyo commented Sep 10, 2025

Before this update, SimpleJson expected to generate the template_name in options[:template]. However, with the Rails 8 upgrade (ref: rails/rails#52984), a value is no longer passed to options[:template].
For example:

Error: test: The renamed template correctly renders a JSON(ActionControllerAPITest):
  ActionView::MissingTemplate: Missing template api/posts/show with {:locale=>[:en], :formats=>[:json], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jb, :jbuilder]}.

Therefore, I modified it to generate the template_name from options[:action].

@AZQ1994 AZQ1994 merged commit 5c130ef into aktsk:master Sep 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants