Skip to content

Conversation

@theLAZYmd
Copy link

No description provided.

Copy link
Owner

@ajGingrich ajGingrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which use cases is it currently failing for you? and what case is this for? I see it as four potential use cases.

  1. inner html -> with nodes and Event data
  2. no inner html -> string with event data
  3. inner html -> no event data
  4. no inner html -> no event data

I see all tests cases except for number 4 working on my current master. However, after applying your changes it breaks every case without fixing number 4.

Thanks for contributing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants