-
Notifications
You must be signed in to change notification settings - Fork 343
Build MVP website from README #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
883b15b
7a9d423
7e33cff
44f490d
55ed3a3
6a80f35
2ae527b
9d2ab0c
49c70c7
b35f858
9fbbe2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| source 'https://rubygems.org' do | ||
| gem "rake", "~> 13.0.0" | ||
| end | ||
| source 'https://rubygems.org' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I reworked this file to address this warning from Bundler:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! |
||
|
|
||
| gem "rake", "~> 13.0.0" | ||
| gem "jekyll", "~> 4.4.1" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,89 @@ | ||
| GEM | ||
| specs: | ||
|
|
||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| addressable (2.8.7) | ||
| public_suffix (>= 2.0.2, < 7.0) | ||
| base64 (0.3.0) | ||
| bigdecimal (3.3.1) | ||
| colorator (1.1.0) | ||
| concurrent-ruby (1.3.5) | ||
| csv (3.3.5) | ||
| em-websocket (0.5.3) | ||
| eventmachine (>= 0.12.9) | ||
| http_parser.rb (~> 0) | ||
| eventmachine (1.2.7) | ||
| ffi (1.17.2) | ||
| ffi (1.17.2-arm64-darwin) | ||
| forwardable-extended (2.6.0) | ||
| google-protobuf (4.33.1) | ||
| bigdecimal | ||
| rake (>= 13) | ||
| google-protobuf (4.33.1-arm64-darwin) | ||
| bigdecimal | ||
| rake (>= 13) | ||
| http_parser.rb (0.8.0) | ||
| i18n (1.14.7) | ||
| concurrent-ruby (~> 1.0) | ||
| jekyll (4.4.1) | ||
| addressable (~> 2.4) | ||
| base64 (~> 0.2) | ||
| colorator (~> 1.0) | ||
| csv (~> 3.0) | ||
| em-websocket (~> 0.5) | ||
| i18n (~> 1.0) | ||
| jekyll-sass-converter (>= 2.0, < 4.0) | ||
| jekyll-watch (~> 2.0) | ||
| json (~> 2.6) | ||
| kramdown (~> 2.3, >= 2.3.1) | ||
| kramdown-parser-gfm (~> 1.0) | ||
| liquid (~> 4.0) | ||
| mercenary (~> 0.3, >= 0.3.6) | ||
| pathutil (~> 0.9) | ||
| rouge (>= 3.0, < 5.0) | ||
| safe_yaml (~> 1.0) | ||
| terminal-table (>= 1.8, < 4.0) | ||
| webrick (~> 1.7) | ||
| jekyll-sass-converter (3.1.0) | ||
| sass-embedded (~> 1.75) | ||
| jekyll-watch (2.2.1) | ||
| listen (~> 3.0) | ||
| json (2.16.0) | ||
| kramdown (2.5.1) | ||
| rexml (>= 3.3.9) | ||
| kramdown-parser-gfm (1.1.0) | ||
| kramdown (~> 2.0) | ||
| liquid (4.0.4) | ||
| listen (3.9.0) | ||
| rb-fsevent (~> 0.10, >= 0.10.3) | ||
| rb-inotify (~> 0.9, >= 0.9.10) | ||
| mercenary (0.4.0) | ||
| pathutil (0.16.2) | ||
| forwardable-extended (~> 2.6) | ||
| public_suffix (6.0.2) | ||
| rake (13.0.6) | ||
| rb-fsevent (0.11.2) | ||
| rb-inotify (0.11.1) | ||
| ffi (~> 1.0) | ||
| rexml (3.4.4) | ||
| rouge (4.6.1) | ||
| safe_yaml (1.0.5) | ||
| sass-embedded (1.94.2) | ||
| google-protobuf (~> 4.31) | ||
| rake (>= 13) | ||
| sass-embedded (1.94.2-arm64-darwin) | ||
| google-protobuf (~> 4.31) | ||
| terminal-table (3.0.2) | ||
| unicode-display_width (>= 1.1.1, < 3) | ||
| unicode-display_width (2.6.0) | ||
| webrick (1.9.1) | ||
|
|
||
| PLATFORMS | ||
| arm64-darwin-23 | ||
| ruby | ||
|
|
||
| DEPENDENCIES | ||
| rake (~> 13.0.0)! | ||
| jekyll (~> 4.4.1) | ||
| rake (~> 13.0.0) | ||
|
|
||
| BUNDLED WITH | ||
| 2.5.4 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1056,6 +1056,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| ] | ||
| ``` | ||
|
|
||
| </details> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed that some details closing tags were missing. |
||
|
|
||
| * <a id='long-typealias'></a>(<a href='#long-typealias'>link</a>) [Long](https://github.com/airbnb/swift#column-width) type aliases of protocol compositions should wrap before the `=` and before each individual `&`. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#wrapArguments) | ||
|
|
||
| <details> | ||
|
|
@@ -1084,6 +1086,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| & UniverseSimulatorServiceProviding | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='sort-typealiases'></a>(<a href='#sort-typealiases'>link</a>) **Sort protocol composition type aliases alphabetically.** [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#sortTypealiases) | ||
|
|
||
| <details> | ||
|
|
@@ -1110,6 +1114,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| & UniverseSimulatorServiceProviding | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='prefer-if-let-shorthand'></a>(<a href='#prefer-if-let-shorthand'>link</a>) Omit the right-hand side of the expression when unwrapping an optional property to a non-optional property with the same name. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#redundantOptionalBinding) | ||
|
|
||
| <details> | ||
|
|
@@ -1142,6 +1148,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| else { … } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='else-on-same-line'></a>(<a href='#else-on-same-line'>link</a>) **Else statements should start on the same line as the previous condition's closing brace, unless the conditions are separated by a blank line or comments.** [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#elseOnSameLine) | ||
|
|
||
| <details> | ||
|
|
@@ -1196,6 +1204,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='multi-line-conditions'></a>(<a href='#multi-line-conditions'>link</a>) **Multi-line conditional statements should break after the leading keyword.** Indent each individual statement by [2 spaces](https://github.com/airbnb/swift#spaces-over-tabs). [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#wrapArguments) | ||
|
|
||
| <details> | ||
|
|
@@ -1609,6 +1619,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='indent-multiline-string-literals'></a>(<a href='#indent-multiline-string-literals'>link</a>) **Indent the body and closing triple-quote of multiline string literals**, unless the string literal begins on its own line in which case the string literal contents and closing triple-quote should have the same indentation as the opening triple-quote. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#indent) | ||
|
|
||
| <details> | ||
|
|
@@ -1779,6 +1791,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='no-spaces-around-function-parens'></a>(<a href='#no-spaces-around-parens'>link</a>) For function calls and declarations, there should be no spaces before or inside the parentheses of the argument list. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#spaceInsideParens) [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#spaceAroundParens) | ||
|
|
||
| <details> | ||
|
|
@@ -3010,6 +3024,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='avoid-global-functions'></a>(<a href='#avoid-global-functions'>link</a>) **Avoid global functions whenever possible.** Prefer methods within type definitions. | ||
|
|
||
| <details> | ||
|
|
@@ -4694,6 +4710,8 @@ _You can enable the following settings in Xcode by running [this script](resourc | |
| } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| * <a id='prefer-throwing-tests'></a>(<a href='#prefer-throwing-tests'>link</a>) **Prefer throwing tests to `try!`**. `try!` will crash your test suite like a force-unwrapped optional. XCTest and Swift Testing support throwing test methods, so use that instead. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#noForceTryInTests) | ||
|
|
||
| <details> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Website | ||
|
|
||
| ## Local development | ||
|
|
||
| To start the local development server, run the following command: | ||
|
|
||
| ```bash | ||
| bundle exec rake site:serve | ||
| ``` | ||
|
|
||
| Once the server is running, open [http://localhost:4000](http://localhost:4000) in your browser to preview the site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually deploying the site? Or just validating that it builds successfully? My guess it that it's just validating the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is validating that it builds. We'll need to add a separate workflow for deployment.