Skip to content

Conversation

@satwiksps
Copy link
Contributor

@satwiksps satwiksps commented Nov 24, 2025

[ENH] Add general estimator test for common input dtypes

Reference Issues/PRs

What does this implement/fix?

This PR introduces a new general estimator test to validate compatibility with common numpy input data types. The test converts the standard aeon testing data to the following dtypes and ensures the estimator continues to run as expected:

  • float32
  • float64
  • int32
  • int64

The new check executes fit and predict (where applicable) using the dtype-converted data and raises a clear failure if an estimator does not support any of these inputs. The check is integrated directly into the existing estimator testing flow.

Does your contribution introduce a new dependency? If yes, which one?

No, this contribution does not introduce any new dependencies.

Any other comments?

  • The implementation follows aeon’s current testing conventions and was validated locally by running targeted estimator checks for the new dtype test.
  • The change is intentionally minimal to reduce risk and avoid impacting unrelated components.
  • If any further modifications, additional test coverage, or structural adjustments are required, I’m happy to update the implementation accordingly.

PR checklist

For all contributions

  • I've added myself to the list of contributors. Alternatively, I will use the @all-contributors bot after the PR is merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV].

For new estimators and functions

  • Not applicable (no new estimators or public functions added).

For developers with write access

  • Not applicable.

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request labels Nov 24, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ enhancement ].
I have added the following labels to this PR based on the changes made: [ testing ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant