Skip to content

use typeof globalThis #9402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
quisido wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use typeof globalThis #9402

quisido wants to merge 1 commit into from
+2 −2

Conversation

@quisido
Copy link

@quisido quisido commented Dec 22, 2025

Closes #9250

@quisido quisido mentioned this pull request Dec 22, 2025
Open
@snowystinger
Copy link
Member

snowystinger commented Dec 22, 2025

I think globalThis needs to be added either via ecmaVersion or in the globals section of eslint

@quisido
Copy link
Author

quisido commented Dec 23, 2025

I think globalThis needs to be added either via ecmaVersion or in the globals section of eslint

The GH issue describes it as a built-in for TypeScript. Is it possible for the CI check to run to validate this via tsc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@react-aria/utils should not depend on @types/node.

2 participants

@quisido @snowystinger