Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Nov 5, 2025

for a build for upcoming test session

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 5, 2025

@nwidynski
Copy link
Contributor

nwidynski commented Nov 5, 2025

@LFDanLu Could you merge once more? I just pushed a typo fix, which was responsible for the scrollPadding issue i flagged in the other PR. Copy-pasta striked once again 🫠

@rspbot
Copy link

rspbot commented Nov 5, 2025

@rspbot
Copy link

rspbot commented Nov 5, 2025

## API Changes

@react-aria/utils

/@react-aria/utils:scrollIntoView

 scrollIntoView {
   scrollView: HTMLElement
   element: HTMLElement
+  opts: ScrollIntoViewOpts
   returnVal: undefined
 }

/@react-aria/utils:scrollIntoViewport

 scrollIntoViewport {
   targetElement: Element | null
-  opts?: ScrollIntoViewportOpts
+  opts: ScrollIntoViewportOpts
   returnVal: undefined
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants