Skip to content

Conversation

@UladzimirLitvinchukAdobe
Copy link
Contributor

@UladzimirLitvinchukAdobe UladzimirLitvinchukAdobe commented Nov 19, 2025

SITES-35060
[SLA3] Regression – Title Component Policy Dialog Throws False “Select at least one size option” Error (SDK 2025.4+)

Problem Description
When editing a Title component policy (design dialog - Template Editor):
• The Allowed Types / Sizes list shows six check-boxes (H1 … H6).
• If an author deselects any one size while at least one other size remains checked, the dialog immediately displays error "Select at least one size option" and does not allow to Save (clicking Done button does not do anything)
• The error should appear only when all sizes are unchecked.

Summary
Fixes incorrect validation in the Title component design dialog: the dialog no longer recognized the full group of size checkboxes due to updated Coral markup, causing inconsistent warnings and the Done button not being disabled when all sizes were unchecked.

Fix

  • Updated the validator to correctly gather all size checkboxes from the shared container.
  • Restored proper group-level validation: error shown only when all sizes are unchecked.
  • Re-enabled dialog-level invalid state so the Done button is correctly disabled again.

Result
Validation works as originally intended:

  • at least one size selected → dialog valid, Done enabled
  • all sizes unselected → error shown, Done disabled
image
Q                       A
Fixed Issues? SITES-35060
[SLA3] Regression – Title Component Policy Dialog Throws False “Select at least one size option” Error (SDK 2025.4+)
Patch: Bug Fix? Bug Fix
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes? no
License Apache License, Version 2.0

@sonarqubecloud
Copy link

Copy link
Contributor

@RaduADumitru RaduADumitru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but another opinion would be helpful as well, I've asked within our team for an additional look


// set the default value of the size dropdown
if (checkboxToggled) {
selectValue = getAppropriateCheckedBoxValue($checkboxes, select.value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method seems to be no longer used since you removed it here, I saw Github Actions is complaining about this. Could you remove the method definition as well? It may fix some of the build failures

Copy link
Contributor

@RaduADumitru RaduADumitru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also saw another PR check failure in the github diff view:

'DATA_ATTR_VALIDATION_STATE' is assigned a value but never used

So if you could remove this as well, it seems it would unblock the rest of the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants