Updated dependencies, added a couple files to gitignore #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DefFoundError: javax/xml/bind/JAXBException
adamzareba
requested changes
Apr 8, 2019
Owner
adamzareba
left a comment
adamzareba
left a comment
There was a problem hiding this comment.
Thanks for that changes. Please do some minor changes in pom.xml as per my comments.
| <dependency> | ||
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <version>2.2.11</version> |
Owner
There was a problem hiding this comment.
Please move all dependencies versions into properties section. It will be easier to maintain it in future.
| <flywaydb.version>5.0.5</flywaydb.version> | ||
| <jackson.version>2.9.5</jackson.version> | ||
| <lombok.version>1.16.20</lombok.version> | ||
| <lombok.version>1.18.6</lombok.version> |
Owner
There was a problem hiding this comment.
Since most of the changes are related to updated java version, then please also change java.version property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated lombok dependency to fix compile error, added fix for NoClassDefFoundError: javax/xml/bind/JAXBException
These two errors were preventing compilation on master, the project was tested and works after the update