Skip to content

Conversation

@Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Oct 8, 2021

I did a few updates to make the admin slightly nicer to use.

  • Disabled add/change
  • Fixed JSON rendering
  • Added search, date_hierarchy and filter to list view
  • Added is_valid field to list view

Also set the model name so the casing is better in menus and translatable

Fixes part of #25

- Disabled add/change
- Fixed JSON rendering
- Added search, date_hierarchy and filter to list view
- Added is_valid field to list view
@adamalton
Copy link
Owner

Thanks.

Does the addition of the has_add_permission and has_change_permission methods mean that all reports become uneditable in the admin and you can't add new ones? I can see that that makes a lot of sense, but I'm not sure whether enforcing it as the default is necessarily what we want to do 🤔 . I would be tempted to just leave that up to the developer of a project, and leave the defaults to be less restrictive. But I'm on the fence about it.

Convince me? 😀

@Bartvaderkin
Copy link
Contributor Author

As this is a logging module for reporting purposes I thought it'd be unlikely you'd add or modify records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants