#4 - Encode screenshot src and href attribute #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jamesomorodion , @abhishekkyd
I noticed the same problem as other people noticed under issue #4 . I looked inside your code and I noticed that inside code the href and src attribute does not encode spaces. After encoding them, everything started to work for me.
I noticed as well second problem.
The screenshot names aren't the same as names created in the reporter if we use this logic:
describe('testSuite', function() {
describe('testSuiteDeeperName', function() {
it('test1', function() {})
expect(2).toBe(1)
})
})
The reporter will expect to find:
'''
testSuite.testSuiteDeeperName test1.png
'''
screenshot, but inside screenshot folder we will find:
'''
testSuite testSuiteDeeperName test1.png
'''
Please let me know if it suits you, or I should fix something.