Skip to content

Conversation

@lukzeg
Copy link

@lukzeg lukzeg commented Sep 23, 2019

Hi @jamesomorodion , @abhishekkyd
I noticed the same problem as other people noticed under issue #4 . I looked inside your code and I noticed that inside code the href and src attribute does not encode spaces. After encoding them, everything started to work for me.

I noticed as well second problem.
The screenshot names aren't the same as names created in the reporter if we use this logic:
describe('testSuite', function() {
describe('testSuiteDeeperName', function() {
it('test1', function() {})
expect(2).toBe(1)
})
})

The reporter will expect to find:
'''
testSuite.testSuiteDeeperName test1.png
'''
screenshot, but inside screenshot folder we will find:
'''
testSuite testSuiteDeeperName test1.png
'''
Please let me know if it suits you, or I should fix something.

Copy link

@jenishgandhi7 jenishgandhi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed issue after I replaced change locally

@lukzeg
Copy link
Author

lukzeg commented Aug 17, 2021

Hi @jenishgandhi7 ,

I'm glad that my fix works for you as well. I have hope that it might be merged by you, so everyone else can use it.

@akshita025
Copy link

Is this available now? I am still facing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants