Skip to content

Conversation

@abenevaut
Copy link
Owner

No description provided.

@abenevaut abenevaut added this to the laravel-google-maps-1.0.0 milestone Oct 1, 2025
@abenevaut abenevaut self-assigned this Oct 1, 2025
Copilot AI review requested due to automatic review settings October 1, 2025 06:37
@abenevaut abenevaut added the Run Run task label Oct 1, 2025
@abenevaut abenevaut moved this to Done in opensource Oct 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the Laravel Google Maps client to support multiple Google Maps services through a factory pattern. The changes migrate from a single client approach to a service-based architecture that can handle different Google Maps APIs.

  • Introduces a factory pattern to manage multiple Google Maps services (Places and Timezones)
  • Replaces the monolithic GoogleMapsClient with specialized service classes
  • Updates configuration structure to support service-specific settings

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
TimezonesService.php New service wrapper for timezone API functionality
PlacesService.php New service wrapper for places API functionality
GoogleMapsServiceFactory.php Factory class to instantiate appropriate services based on driver name
GoogleMapsServiceProvider.php Updated Laravel service provider to register new services and factory
GoogleMapsServiceInterface.php New interface defining common service contract
GoogleMaps.php Updated facade to use the new factory instead of direct client
TimezonesClient.php New HTTP client specifically for Google Maps Timezone API
PlacesClient.php Refactored from GoogleMapsClient to focus on Places API
google-maps.php New configuration file for service-specific settings
README.md Updated usage examples to reflect new API structure
Contribute.md Removed Docker setup instructions
Files not reviewed (1)
  • .idea/phpunit.xml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Run Run task

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants