Mail: Temporary Failover Fix to Avoid Sender Issues #10613
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Well, this LGTM, but I have zero experience with sendmail, so I defer to someone who does for final approval.
|
|
||
| try { | ||
| $phpmailer->setFrom( $from_email, $from_name ); | ||
| // Passing $auto can be removed once PHPMailer supports setting the envelope sender separately. See <https://core.trac.wordpress.org/ticket/64368>. |
There was a problem hiding this comment.
will the PHPMailer update make this line irrelevant, or will the update make it possible for people to work around the issue?
asking to clarify whether the default behavior with the PHPMailer update will be that the people experiencing their issue will find it resolved. also, with the update, will this line still be useful or benign? or will this workaround interfere with the PHPMailer update/will the PHPMailer update interfere with this workaround?
There was a problem hiding this comment.
@dmsnell yes, the PHPMailer update will make this a duplicate check. Leaving this will not do any harm, but I will make sure that I remove this lines once the library gets updated.
We could leave this on hold because there is a chance the PHPMailer update gets sooner than this. But if anyone wants to push it just to make sure it gets fixed, I will have an eye on it.
3 participants
Since I can't be 100% sure that PHPMailer will update on time for 6.9.1 and I don't really know when 6.9.1 is schedule for release, I'm providing here a failover as @dmsnell suggested.
Trac ticket: https://core.trac.wordpress.org/ticket/64368
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.