-
Notifications
You must be signed in to change notification settings - Fork 828
Run spec tests in parallel to reduce the execution time #8088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
44c5834 to
62b613b
Compare
62b613b to
bb0d612
Compare
|
The alpine builder has been running for over three hours now, so I think there's a problem here. Looking at the log, it looks much more verbose than before because the stdout from the wasm-shell commands is being printed. Maybe fixing that will make the builder go faster? |
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % open comments
|
Re:
I changed |
|
I think the CI problem is that this member isn't initialized in the default constructor of SmallVector since std::array is an aggregate type. I'm not sure why we see the breakage here and not in main or in other architectures. I'll try to re-run for now and send a PR to fix separately. |
|
About the |
Reduces runtime from ~15 minutes to 1.5 minutes on my machine
Before:

After:

Failed test example (stdout and stderr isn't ordered with the exception unfortunately, but it's easy to re-run the particular test):

os.cpu_count() * 2threadsos.cpu_count() * 4shows no benefit.os.cpu_count()oros.cpu_count() // 2also show no regression in runtime, but might be worse for machines with less cores. There are currently 315 spec tests total for reference.