fix: use lowercase for file extension in mime type retrieval #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue in the Android implementation where the Kotlin method
toLowerCase()was used to normalize the file extension before retrieving its MIME type.In newer Kotlin versions,
toLowerCase()has been deprecated in favor oflowercase(), which is locale-safe and avoids potential runtime warnings or compatibility issues.Motivation
When using this library with modern Android projects (Kotlin 1.5+), the deprecated toLowerCase() method can trigger compilation warnings or even cause build failures depending on lint settings.
Replacing it with lowercase() ensures forward compatibility and adheres to Kotlin best practices.
Implementation
extension.toLowerCase()with:
extension.lowercase()Impacted area
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md