-
Notifications
You must be signed in to change notification settings - Fork 36
Dependabot/npm and yarn/storybook/addon onboarding 10.0.0 #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dependabot/npm and yarn/storybook/addon onboarding 10.0.0 #570
Conversation
Bumps [@storybook/addon-onboarding](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/onboarding) from 9.1.15 to 10.0.0. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.0.0/code/addons/onboarding) --- updated-dependencies: - dependency-name: "@storybook/addon-onboarding" dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
✅ Deploy Preview for fireproof-ai-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| it( | ||
| "should generate 30 unique slugs with no repeats", | ||
| { timeout: 10000 }, | ||
| () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass timeout as number, not options object
Vitest’s it signature is it(name, fn, timeout?), so the second argument must be the test function. Lines 5‑8 now pass an options object { timeout: 10000 } as the second parameter and the actual callback as the third, which causes Vitest to throw at runtime (TypeError: fn is not a function) and prevents the suite from running at all. If you need a longer timeout you must keep the callback as the second argument and pass 10000 as the third parameter (or use the newer test.runIf helpers).
Useful? React with 👍 / 👎.

No description provided.