Merge pull request #131 from VectorInstitute/fix-json-format

Fix json format for launch command

Author: XkunW

tests/vec_inf/cli/test_helper.py

@@ -1,5 +1,6 @@
 """Tests for the CLI helper classes."""
 
+import json
 from unittest.mock import MagicMock, patch
 
 from rich.console import Console
@@ -218,10 +219,11 @@ def test_output_json_ready_status(self, mock_echo):
         formatter.output_json()
 
         mock_echo.assert_called_once()
-        # Just check that it was called with a dict
+        # Just check that it was called with a json compatible string
         output = mock_echo.call_args[0][0]
-        assert isinstance(output, dict)
-        assert "model_name" in output
+        json_dict = json.loads(output)
+        assert isinstance(json_dict, dict)
+        assert "model_name" in json_dict
 
     @patch("click.echo")
     def test_output_json_with_error_reasons(self, mock_echo):
@@ -242,9 +244,10 @@ def test_output_json_with_error_reasons(self, mock_echo):
 
         mock_echo.assert_called_once()
         output = mock_echo.call_args[0][0]
-        assert isinstance(output, dict)
-        assert "pending_reason" in output
-        assert "failed_reason" in output
+        json_dict = json.loads(output)
+        assert isinstance(json_dict, dict)
+        assert "pending_reason" in json_dict
+        assert "failed_reason" in json_dict
 
 
 class TestMetricsResponseFormatter:

vec_inf/cli/_helper.py

@@ -4,6 +4,7 @@
 handling the presentation of model information, status updates, and metrics.
 """
 
+import json
 from pathlib import Path
 from typing import Any, Union
 
@@ -27,9 +28,8 @@ class LaunchResponseFormatter:
     Parameters
     ----------
     model_name : str
-        Name of the launched model
-    params : dict[str, Any]
-        Launch parameters and configuration
+        Name of the launched model    params : dict[str, Any] Launch parameters and
+            configuration
     """
 
     def __init__(self, model_name: str, params: dict[str, Any]):
@@ -176,7 +176,12 @@ def output_json(self) -> None:
             json_data["pending_reason"] = self.status_info.pending_reason
         if self.status_info.failed_reason:
             json_data["failed_reason"] = self.status_info.failed_reason
-        click.echo(json_data)
+
+        # Convert dict to json compliant string with double quotes
+        json_string = json.dumps(json_data)
+
+        # Output json to console
+        click.echo(json_string)
 
     def output_table(self) -> Table:
         """Create and display rich table.