Fixed some tests and formatting errors

Author: scarere

tests/vec_inf/cli/test_helper.py

@@ -1,5 +1,6 @@
 """Tests for the CLI helper classes."""
 
+import json
 from unittest.mock import MagicMock, patch
 
 from rich.console import Console
@@ -218,10 +219,11 @@ def test_output_json_ready_status(self, mock_echo):
         formatter.output_json()
 
         mock_echo.assert_called_once()
-        # Just check that it was called with a dict
+        # Just check that it was called with a json compatible string
         output = mock_echo.call_args[0][0]
-        assert isinstance(output, dict)
-        assert "model_name" in output
+        json_dict = json.loads(output)
+        assert isinstance(json_dict, dict)
+        assert "model_name" in json_dict
 
     @patch("click.echo")
     def test_output_json_with_error_reasons(self, mock_echo):
@@ -242,9 +244,10 @@ def test_output_json_with_error_reasons(self, mock_echo):
 
         mock_echo.assert_called_once()
         output = mock_echo.call_args[0][0]
-        assert isinstance(output, dict)
-        assert "pending_reason" in output
-        assert "failed_reason" in output
+        json_dict = json.loads(output)
+        assert isinstance(json_dict, dict)
+        assert "pending_reason" in json_dict
+        assert "failed_reason" in json_dict
 
 
 class TestMetricsResponseFormatter:

vec_inf/cli/_helper.py

@@ -28,7 +28,8 @@ class LaunchResponseFormatter:
     Parameters
     ----------
     model_name : str
-        Name of the launched model    params : dict[str, Any] Launch parameters and configuration
+        Name of the launched model    params : dict[str, Any] Launch parameters and
+            configuration
     """
 
     def __init__(self, model_name: str, params: dict[str, Any]):
@@ -115,14 +116,28 @@ def format_table_output(self) -> Table:
         for model_name in self.params["models"]:
             table.add_row("Model Name", model_name, style="magenta")
             # Add resource allocation details
-            table.add_row("Partition", f"  {self.params['models'][model_name]['partition']}")
+            table.add_row(
+                "Partition", f"  {self.params['models'][model_name]['partition']}"
+            )
             table.add_row("QoS", f"  {self.params['models'][model_name]['qos']}")
-            table.add_row("Time Limit", f"  {self.params['models'][model_name]['time']}")
-            table.add_row("Num Nodes", f"  {self.params['models'][model_name]['num_nodes']}")
-            table.add_row("GPUs/Node", f"  {self.params['models'][model_name]['gpus_per_node']}")
-            table.add_row("CPUs/Task", f"  {self.params['models'][model_name]['cpus_per_task']}")
-            table.add_row("Memory/Node", f"  {self.params['models'][model_name]['mem_per_node']}")
-            table.add_row("Log Directory", f"  {self.params['models'][model_name]['log_dir']}")
+            table.add_row(
+                "Time Limit", f"  {self.params['models'][model_name]['time']}"
+            )
+            table.add_row(
+                "Num Nodes", f"  {self.params['models'][model_name]['num_nodes']}"
+            )
+            table.add_row(
+                "GPUs/Node", f"  {self.params['models'][model_name]['gpus_per_node']}"
+            )
+            table.add_row(
+                "CPUs/Task", f"  {self.params['models'][model_name]['cpus_per_task']}"
+            )
+            table.add_row(
+                "Memory/Node", f"  {self.params['models'][model_name]['mem_per_node']}"
+            )
+            table.add_row(
+                "Log Directory", f"  {self.params['models'][model_name]['log_dir']}"
+            )
 
         return table
 
@@ -342,7 +357,9 @@ def __init__(self, console: Console, json_mode: bool = False):
         self.model_config = None
         self.model_names: list[str] = []
 
-    def _format_single_model_output(self, config: ModelConfig) -> Union[dict[str, Any], Table]:
+    def _format_single_model_output(
+        self, config: ModelConfig
+    ) -> Union[dict[str, Any], Table]:
         """Format output table for a single model.
 
         Parameters
@@ -360,7 +377,9 @@ def _format_single_model_output(self, config: ModelConfig) -> Union[dict[str, An
             excluded = {"venv", "log_dir"}
             config_dict = config.model_dump(exclude=excluded)
             # Convert Path objects to strings
-            config_dict["model_weights_parent_dir"] = str(config_dict["model_weights_parent_dir"])
+            config_dict["model_weights_parent_dir"] = str(
+                config_dict["model_weights_parent_dir"]
+            )
             return config_dict
 
         table = create_table(key_title="Model Config", value_title="Value")
@@ -373,7 +392,9 @@ def _format_single_model_output(self, config: ModelConfig) -> Union[dict[str, An
                     table.add_row(f"  {vllm_arg}:", str(vllm_value))
         return table
 
-    def _format_all_models_output(self, model_infos: list[ModelInfo]) -> Union[list[str], list[Panel]]:
+    def _format_all_models_output(
+        self, model_infos: list[ModelInfo]
+    ) -> Union[list[str], list[Panel]]:
         """Format output table for all models.
 
         Parameters