Skip to content

Improve notebook generation #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2025
Merged

Improve notebook generation #670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f910b78
Improve notebook generation
penelopeysm Dec 4, 2025
e4a9186
this isn't python
penelopeysm Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions assets/scripts/notebooks/notebooks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function fix_callouts(md_content::AbstractString)::String
# Quarto callouts look like, for example, `::: {.callout-note}`
# There isn't a good Jupyter equivalent, so we'll just use blockquotes.
# https://github.com/quarto-dev/quarto-cli/issues/1167
callout_regex = r"^:::\s*\{\.callout-\w+\}.*$"
callout_regex = r"^:::\s*\{\.callout-.+\}.*$"
callout_end_regex = r"^:::\s*$"
new_lines = String[]
in_callout = false
Expand Down Expand Up @@ -116,9 +116,15 @@ function parse_cells(qmd_path::String)::Notebook
lang = match.captures[1]
code = strip(match.captures[2])
if lang == "julia"
cell = JuliaCodeCell(code)
push!(cells, cell)
union!(packages, extract_imports(cell))
if occursin(r"#|\s*eval:\s*false", code)
# This is a code cell that is not meant to be executed.
push!(cells, MarkdownCell("```julia\n$code\n```"))
continue
else
cell = JuliaCodeCell(code)
push!(cells, cell)
union!(packages, extract_imports(cell))
end
else
# There are some code cells that are not Julia for example
# dot and mermaid. You can see what cells there are with
Expand Down
Loading