Skip to content

Conversation

@djanowski
Copy link
Contributor

No description provided.

@bobrik
Copy link
Contributor

bobrik commented Sep 21, 2015

cc @r3nat

@jmealo
Copy link
Contributor

jmealo commented Sep 21, 2015

@djanowski This doesn't work on OSX. I fixed it in #9

I had issues building on OpenVZ in Ubuntu 14.04, however the default image on GCE worked fine... so this should be good to go in #9 if you want to close this or pull in my OSX fixes. It doesn't matter to me.

@jmealo jmealo mentioned this pull request Sep 21, 2015
Node 4.0 compatible and OSX build fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Nan::NewBuffer() internally call realloc() for the buffer? If not, it should be called before Nan::NewBuffer(), because now the code always returns bytesIn + 100 bytes (with result bytes stored in it).

@fadimko
Copy link
Contributor

fadimko commented Oct 22, 2015

upd:

  • Nan::NewBuffer() doesn't call realloc().
  • size_t Length(v8::Local<v8::Value> val); and char* Data(v8::Local<v8::Value> val); seems to work fine.

@r3nat @bobrik I don't know much about npm's versioning policy, so should we bump addon's major version (new code uses nan2, which is incompatible with previous versions)?

@fadimko
Copy link
Contributor

fadimko commented Nov 8, 2015

Silence..

Merged 59a9767 with fixes and 42b6f88.

@fadimko fadimko closed this Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants