Skip to content

Fix package config on Windows #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mojaveazure wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix package config on Windows #784

mojaveazure wants to merge 1 commit into from

Conversation

@mojaveazure
Copy link
Member

@mojaveazure mojaveazure commented Dec 10, 2024

Fix issues with .pkg_config() on Windows; include new include and linking flags as suggested by @LTLA

SC-60076

resolves #780

ihnorton
ihnorton reviewed Dec 16, 2024
View reviewed changes
R/Version.R
c("Secur32", "Crypt32"),
"NCrypt",
c(
"BCrypt",
Copy link
Member

@ihnorton ihnorton Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this replacing the makevars?

TileDB-R/src/Makevars.win

Line 16 in b5e8191

-lBCrypt -lKernel32 -lRpcrt4 -lWininet -lWinhttp -lWs2_32 -lShlwapi -lUserenv -lversion -lws2_32 \

Copy link
Member Author

@mojaveazure mojaveazure Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihnorton Not for tiledb-r, but for any package downstream that links to libtiledb bundled with tiledb-r on Windows

@mojaveazure
Fix package config on Windows
74ae1af 
Fix issues with `.pkg_config()` on Windows; include new include and
linking flags as suggested by @LTLA

[SC-60076](https://app.shortcut.com/tiledb-inc/story/60076)

resolves #780
@mojaveazure mojaveazure force-pushed the paulhoffman/sc-60076/providing-access-to-the-tiledb-r-shared-libraries branch from bb93142 to 74ae1af Compare January 24, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihnorton ihnorton ihnorton left review comments

+1 more reviewer

@johnkerl johnkerl johnkerl approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

API packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Providing access to the TileDB-R shared libraries in downstream packages

4 participants

@mojaveazure @ihnorton @johnkerl