Skip to content

Simplify DummyClass by removing unused dependencies #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2025
Merged

Simplify DummyClass by removing unused dependencies #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b951465
Simplified `DummyClass` by removing unused dependencies and attributes
andrey-helldar Sep 14, 2025
1c9e556
Merge remote-tracking branch 'origin/1.x' into 1.x
andrey-helldar Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions stubs/converter.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,12 @@ namespace DummyNamespace;
use DragonCode\LaravelFeed\Converters\Converter;
use DragonCode\LaravelFeed\Feeds\Feed;
use DragonCode\LaravelFeed\Feeds\Items\FeedItem;
use DragonCode\LaravelFeed\Services\TransformerService;
use Illuminate\Container\Attributes\Config;

use function implode;
use function is_array;
use function json_encode;

class DummyClass extends Converter
{
public function __construct(
#[Config('feeds.converters.jsonl.options')]
protected int $options,
TransformerService $transformer
) {
parent::__construct(false, $transformer);
}

public function header(Feed $feed): string
{
return '';
Expand Down Expand Up @@ -69,6 +59,6 @@ class DummyClass extends Converter

protected function encode(array $data): string
{
return json_encode($data, $this->options);
return implode(';', $data);
}
}