-
-
Notifications
You must be signed in to change notification settings - Fork 566
fix(form-core): Prevent runtime errors during validation #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form-core): Prevent runtime errors during validation #1948
Conversation
🦋 Changeset detectedLatest commit: f68391c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Prevent runtime errors that occur during form validation in the form-core package.
|
View your CI Pipeline Execution ↗ for commit f68391c
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
- Coverage 90.35% 89.43% -0.93%
==========================================
Files 38 48 +10
Lines 1752 1940 +188
Branches 444 487 +43
==========================================
+ Hits 1583 1735 +152
- Misses 149 184 +35
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a regression by #1691 , where conditional checks were removed. The PR reintroduces the checks plus a warning to not remove them.