Skip to content

Conversation

@HM-23-HM
Copy link
Contributor

🎯 Changes

These are some suggestions I have for how we could improve this page. It's mostly grammar and inconsistency fixes, but includes slight re-wording to improve clarity. I'm open to feedback.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Hey team,

These are some suggestions I have for how we could improve this page. It's mostly grammar and consistency fixes, but includes slight re-wording to improve clarity. I'm open to feedback.
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 958ba71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I don't want to come across as too nitpicky, but this is really close to being perfect.

The PR also has good timing, since there's some plans to revamp the structure of pages like this one. Might as well iron out bad phrasing and structure before refactoring it.

Thanks for going over it!

@LeCarbonator
Copy link
Contributor

Oh, I didn't mention it in the review, but since this page will have a refactor soon, I don't think porting all changes to the other frameworks is needed. We'll use the wording of the React file as reference.

@HM-23-HM
Copy link
Contributor Author

HM-23-HM commented Dec 20, 2025

Thanks for the feedback @LeCarbonator. It wasn't too nitpicky. I've made the necessary changes, so let me know what you think.

Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes!

@LeCarbonator LeCarbonator merged commit d2ae76a into TanStack:main Dec 21, 2025
1 check passed
@HM-23-HM HM-23-HM deleted the patch-1 branch December 21, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants