-
-
Notifications
You must be signed in to change notification settings - Fork 566
[Docs] Refine language and formatting in react basic concepts guide #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey team, These are some suggestions I have for how we could improve this page. It's mostly grammar and consistency fixes, but includes slight re-wording to improve clarity. I'm open to feedback.
|
LeCarbonator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I don't want to come across as too nitpicky, but this is really close to being perfect.
The PR also has good timing, since there's some plans to revamp the structure of pages like this one. Might as well iron out bad phrasing and structure before refactoring it.
Thanks for going over it!
|
Oh, I didn't mention it in the review, but since this page will have a refactor soon, I don't think porting all changes to the other frameworks is needed. We'll use the wording of the React file as reference. |
|
Thanks for the feedback @LeCarbonator. It wasn't too nitpicky. I've made the necessary changes, so let me know what you think. |
LeCarbonator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes!
🎯 Changes
These are some suggestions I have for how we could improve this page. It's mostly grammar and inconsistency fixes, but includes slight re-wording to improve clarity. I'm open to feedback.
✅ Checklist
pnpm test:pr.🚀 Release Impact