Store primitives in a vector in the interpreter #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartenS11
force-pushed
the
refactor/primitive-vector
branch
2 times, most recently
from
04c2e5b to
400a3a6
Compare
Member
|
@MaartenS11 this looks pretty complete to me. What is holding this PR back from being merged? (I don't mind fixing something if it can help) |
Member
Author
|
It is indeed pretty complete, I might later make some changes (I'll do that in other PRs) but this already removes a lot of boilerplate. I only think reversibility might not work so I should test that with a simple example to make sure, but it would be easy to fix. I also think we should merge this before the mutable globals since that can help reduce duplication in that PR. |
Member
|
That is good to know. I think we can resume this after the ECOOP deadline. |
MaartenS11
changed the title
Tested this in the emulator, and it works fine, since the code is shared now it should also work on physical hardware.
TODO: Fix prints in the Interpreter class
Also removed some other unnecessary header files in WARDuino.h.
MaartenS11
force-pushed
the
refactor/primitive-vector
branch
from
19140e7 to
bddce1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #323.
This PR moves the primitive table from each of the platforms to a vector that is a member of the interpreter. This way a lot of code can be deduplicated between the platforms and primitives can be added dynamically.