Implement several other hot-path performance improvements:

- return early in get_property() for simple types that do not require additional wrapping
- dedent description text once during elaboration rather than multiple times when querying
- intern property strings to improve speed of lookups

Author: amykyta3

src/systemrdl/core/elaborate.py

@@ -2,7 +2,7 @@
 from typing import TYPE_CHECKING, List, Optional, cast
 
 from ..ast import ASTNode
-from .helpers import is_pow2, roundup_pow2, roundup_to
+from .helpers import is_pow2, roundup_pow2, roundup_to, dedent_text
 from .value_normalization import normalize, RefInParameterError
 
 from .. import component as comp
@@ -39,7 +39,10 @@ def enter_Component(self, node: Node) -> None:
         # Evaluate component properties
         for prop_name, prop_value in node.inst.properties.items():
             if isinstance(prop_value, ASTNode):
-                node.inst.properties[prop_name] = prop_value.get_value(assignee_node=node)
+                v = prop_value.get_value(assignee_node=node)
+                if prop_name == "desc" and node.env.dedent_desc:
+                    v = dedent_text(v)
+                node.inst.properties[prop_name] = v
 
 
     def enter_AddressableComponent(self, node: AddressableNode) -> None:

src/systemrdl/node.py

@@ -453,18 +453,19 @@ def get_property(self, prop_name: str, **kwargs: Any)-> Any:
         # Property WAS indeed assigned by the user
         prop_value = self.inst.properties[prop_name]
 
+        if isinstance(prop_value, (rdltypes.BuiltinEnum, str, int)):
+            # Optimization: Exit early to skip comparisons for popular simple return types
+            return prop_value
         if isinstance(prop_value, rdltypes.ComponentRef):
             # If this is a hierarchical component reference, convert it to a Node reference
-            prop_value = prop_value.build_node_ref(self)
-        elif isinstance(prop_value, rdltypes.PropertyReference):
-            prop_value = prop_value.get_resolved_ref(self)
-        elif isinstance(prop_value, list):
+            return prop_value.build_node_ref(self)
+        if isinstance(prop_value, rdltypes.PropertyReference):
+            return prop_value.get_resolved_ref(self)
+        if isinstance(prop_value, list):
             # Inspect array and resolve any references
-            prop_value = rdltypes.references.resolve_node_refs_in_array(self, prop_value)
-        elif rdltypes.is_user_struct(type(prop_value)):
-            prop_value = rdltypes.references.resolve_node_refs_in_struct(self, prop_value)
-        elif (prop_name == "desc") and self.env.dedent_desc:
-            prop_value = helpers.dedent_text(prop_value)
+            return rdltypes.references.resolve_node_refs_in_array(self, prop_value)
+        if rdltypes.is_user_struct(type(prop_value)):
+            return rdltypes.references.resolve_node_refs_in_struct(self, prop_value)
 
         return prop_value
 

src/systemrdl/properties/bases.py

@@ -1,4 +1,5 @@
 from typing import Any, Set, Type, Tuple, TYPE_CHECKING, Optional, Dict
+import sys
 
 from .. import node as m_node
 from ..ast.ast_node import ASTNode
@@ -33,15 +34,16 @@ class PropertyRule:
 
     def __init__(self, env: 'RDLEnvironment'):
         self.env = env
+        self._name = self.get_name_cls()
 
 
     @classmethod
     def get_name_cls(cls) -> str:
-        return cls.__name__.replace("Prop_", "")
+        return sys.intern(cls.__name__.replace("Prop_", ""))
 
 
     def get_name(self) -> str:
-        return self.get_name_cls()
+        return self._name
 
 
     def assign_value(self, comp_def: 'comp.Component', value: Any, src_ref: 'SourceRefBase') -> None:
@@ -286,7 +288,7 @@ def _get_mutex_properties(group_name: str) -> Set[str]:
             if prop_cls.__name__.startswith("Prop_"):
                 if prop_cls.mutex_group is not None:
                     if prop_cls.mutex_group not in _MUTEX_PROP_GROUPS:
-                        _MUTEX_PROP_GROUPS[prop_cls.mutex_group] = set()
-                    _MUTEX_PROP_GROUPS[prop_cls.mutex_group].add(prop_cls.get_name_cls())
+                        _MUTEX_PROP_GROUPS[sys.intern(prop_cls.mutex_group)] = set()
+                    _MUTEX_PROP_GROUPS[sys.intern(prop_cls.mutex_group)].add(prop_cls.get_name_cls())
 
     return _MUTEX_PROP_GROUPS[group_name]

src/systemrdl/rdltypes/references.py

@@ -119,6 +119,8 @@ def __init__(self, src_ref: Optional['SourceRefBase'], env: 'RDLEnvironment', co
         #: property is being referenced.
         self.node: Node
 
+        self._name = self.get_name()
+
     def __repr__(self) -> str:
         return f"<{self.__class__.__qualname__} {self.node.get_path()}->{self.name} at {id(self):#x}>"
 
@@ -139,7 +141,7 @@ def name(self) -> str:
         """
         Name of the property being referenced
         """
-        return self.get_name()
+        return self._name
 
     @classmethod
     def get_name(cls) -> str: