Refactor Existing Database Connection Logic to use SQLAlchemy #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces SQLAlchemy for improved database handling, including connection pooling and enhanced query execution. The Database class now utilizes SQLAlchemy's Engine for managing connections, allowing for better concurrency and resource management. BREAKING CHANGE: The connection handling has been refactored to use SQLAlchemy, which may affect existing database interaction methods.
- Improved database connection management using SQLAlchemy's session system. - Improved query sanitization/safety using SQLAlchemy. - Updated the CLI and test files to utilize the Database class instead of MemDB.
Added comprehensive validation for SQL identifiers and SQLite column types, ensuring safety against reserved words and format issues. Introduced helper methods for building column definitions and mapping SQLite types to SQLAlchemy types, improving the robustness of table creation functionality.
Owner
SyntaxAerror
left a comment
SyntaxAerror
left a comment
There was a problem hiding this comment.
This branch is being abandoned in favor of rewrite-with-sqlalchemy which was merged in #9 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.