Skip to content

STAC-24021: Increase Clickhouse Backup API timeouts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viliakov merged 1 commit into from
Dec 18, 2025
Merged

STAC-24021: Increase Clickhouse Backup API timeouts #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/clickhouse/check_and_finalize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func checkAndFinalize(appCtx *app.Context, operationID string, waitForComplete b
}

// Restore still running
appCtx.Logger.Infof("Restore is still in progress (status: %s)", status)
appCtx.Logger.Infof("Restore is still in progress (status: %s)", status.Status)

// Status is "in progress" or other
if waitForComplete {
Expand Down
4 changes: 2 additions & 2 deletions internal/clients/clickhouse/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (

const (
defaultHTTPClientTimeout = 30 * time.Second
defaultOperationTimeout = 30 * time.Second
defaultOperationTimeout = 900 * time.Second
defaultOperationPollInterval = 2 * time.Second
)

Expand Down Expand Up @@ -182,7 +182,7 @@ func (c *Client) waitForAction(ctx context.Context, operationID string, timeout,
case <-ticker.C:
action, err := c.GetRestoreStatus(ctx, operationID)
if err != nil {
return nil, fmt.Errorf("fail to get action with operation id: %s", operationID)
return nil, fmt.Errorf("fail to get action with operation id=%s : %w", operationID, err)
}
if action.Status == "success" || action.Status == "error" {
return action, nil
Expand Down